[wp-trac] [WordPress Trac] #33646: #a11y-headings - the Screen Options h5

[WordPress Trac]

#33646: #a11y-headings - the Screen Options h5
----------------------------+--------------------------------
 Reporter:  afercia         |       Owner:  joedolson
     Type:  defect (bug)    |      Status:  accepted
 Priority:  normal          |   Milestone:  4.4
Component:  Administration  |     Version:  4.3
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:  ui, accessibility
----------------------------+--------------------------------
Changes (by afercia):

 * keywords:  has-patch needs-testing => has-patch
 * focuses:  accessibility => ui, accessibility


Comment:

 A couple of weeks ago we discussed a bit this ticket in the a11y meeting
 on Slack, agreed to try to find a new approach, avoid nested fieldsets and
 have cleaner markup. I'm a bit late but here's a first refreshed patch
 which tries to do that :)
 Thinking at what's displayed inside the "Screen Options" tab, there are
 different groups of things, they're logically different and have different
 goals. Nonetheless, there's usually just one "title" to identify all of
 them and it's "Show on screen". Maybe, a better approach would be wrapping
 each group in a `<fieldset>` and give each group a unique `<legend>` as
 "title".
 As far as I can see, there are 5 groups:

 {{{
 - meta boxes
 - list table columns
 - layout columns
 - per page setting
 - screen settings (e.g. expand editor, widgets accessibility mode. This is
 the place where plugins usually add their own stuff)
 }}}

 These groups are displayed conditionally in the admin screens and witht he
 patch applied, each group will have its own proper semantic. We shouldn't
 worry anymore about a "wrapper fieldset" or mess with conditionals.

 Special care should be taken in choosing a proper label text, would need
 some native English speaker help for this :) The temporary legend text
 are:

 {{{
 - Boxes to show on screen
 - Display columns
 - Layout columns
 - Pagination settings
 - Additional settings
 }}}

 Also, the patch avoids to output the "Enable accessibility mode" links
 inside a form.

 Example with the patch applied in the Edit Post screen:

 [[Image(https://cldup.com/1dJETroqVI.png)]]

 Example with additional settings appended by plugins, some of them provide
 their own "titles", some not:

 [[Image(https://cldup.com/invAGz8xoU.png)]]

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33646#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform