[wp-trac] [WordPress Trac] #23473: Performance Improvement in three JavaScript Source Codes

[WordPress Trac]

#23473: Performance Improvement in three JavaScript Source Codes
------------------------------------+--------------------------------------
 Reporter:  yongbae                 |       Owner:  adamsilverstein
     Type:  enhancement             |      Status:  assigned
 Priority:  normal                  |   Milestone:  Awaiting Review
Component:  Administration          |     Version:  3.5
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch needs-        |     Focuses:  javascript, performance
  refresh                           |
------------------------------------+--------------------------------------
Changes (by adamsilverstein):

 * owner:   => adamsilverstein
 * status:  new => assigned


Comment:

 Hey @yongbae!

 A belated thanks for your effort and patch. Curious what motivated you to
 analyze and then improve the performance of these JS files? We could
 really use your help optimizing the JS running the customizer if you are
 up for more :)

 The original patch no longer applies, at all.

 I reviewed the optimizations in the patch.

 The changes to the tag regex, now in tags-box.js are minor, making some
 selected items for replacement optional. I don't think its worth changing
 the regex and risk some unexpected consequences, so I am dropping this
 change.

 The optimization in media-views.js makes sense, it avoids setting up
 `views` and `hide` when they aren't getting used. Keeping that.

 The optimization in util.js makes sense; don't set up date unless using,
 and cache the expensive parseInt call. Nice.

 Refreshed patch incoming.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/23473#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform