[wp-trac] [WordPress Trac] #34204: Add fallabacks for WP oEmbed JavaScript & CSS (was: Ensure WP oEmbed JavaScript runs error free)

WordPress Trac noreply at wordpress.org
Thu Oct 8 21:22:18 UTC 2015


#34204: Add fallabacks for WP oEmbed JavaScript & CSS
-------------------------------------+-------------------------
 Reporter:  peterwilsoncc            |       Owner:
     Type:  enhancement              |      Status:  new
 Priority:  normal                   |   Milestone:  4.4
Component:  Embeds                   |     Version:  trunk
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-refresh  |     Focuses:  javascript
-------------------------------------+-------------------------

Old description:

> Add the following to each of the WP oEmbed JavaScript to avoid potential
> for errors:
>
> * `window.load` fallback for `document.DOMContentLoaded` event
> * feature detects presence of `addEventListener` and
> `document.querySelector` before attempting to run
>
> I'm in two minds about each of these to be honest (more so the event
> fallback), will leave to another to decide.

New description:

 Improve JavaScript and CSS support for IE8+, fallbacks include:

 * those listed below
 * PNG fallbacks for icons (IE9-)
 * feature detect `select` and `focus`

 Original description follows:
 ----

 Add the following to each of the WP oEmbed JavaScript to avoid potential
 for errors:

 * `window.load` fallback for `document.DOMContentLoaded` event
 * feature detects presence of `addEventListener` and
 `document.querySelector` before attempting to run

 I'm in two minds about each of these to be honest (more so the event
 fallback), will leave to another to decide.

--

Comment (by peterwilsoncc):

 There is some additional feature detection & error checking I need to do
 to expand browser support. I will upload refresh Sat or Sunday evening USA
 time.

 @melchoyce are you able to upload some PNG fallbacks for the icons?

 I've modified the the description and title to reflect browser support
 rather than specific JS support.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34204#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list