[wp-trac] [WordPress Trac] #34204: Ensure WP oEmbed JavaScript runs error free

WordPress Trac noreply at wordpress.org
Thu Oct 8 03:15:45 UTC 2015


#34204: Ensure WP oEmbed JavaScript runs error free
-------------------------------------+-------------------------
 Reporter:  peterwilsoncc            |       Owner:
     Type:  enhancement              |      Status:  new
 Priority:  normal                   |   Milestone:  4.4
Component:  Embeds                   |     Version:  trunk
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-refresh  |     Focuses:  javascript
-------------------------------------+-------------------------
Changes (by peterwilsoncc):

 * keywords:  has-patch => has-patch needs-refresh


Comment:

 Replying to [comment:3 pento]:
 > `querySelector` is only a problem for IE < 8. I'd like to at least have
 some sort of vaguely working fallback - the share dialog working, at a
 minimum.

 Coolio, can do. A few questions:

 * SVG share icons will need a fallback for IE < 9, text, external PNG or
 inline PNG?
 * Any objection to adding in some IDs for the share dialog fallback? I'd
 like to avoid selecting a tonne of elements and checking `className`.

 Note to self: feature check `focus()` in refresh.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34204#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list