[wp-trac] [WordPress Trac] #17817: do_action/apply_filters/etc. recursion on same filter kills underlying call

[WordPress Trac]

#17817: do_action/apply_filters/etc. recursion on same filter kills underlying call
-------------------------------------------------+-------------------------
 Reporter:  kernfel                              |       Owner:
     Type:  defect (bug)                         |      Status:  reviewing
 Priority:  normal                               |   Milestone:  Future
Component:  Plugins                              |  Release
 Severity:  normal                               |     Version:  2.2
 Keywords:  has-unit-tests has-patch needs-      |  Resolution:
  testing                                        |     Focuses:
-------------------------------------------------+-------------------------

Comment (by nacin):

 Some of you may know that I have been playing with this patch for a few
 weeks with the intention of committing it. I also played with it on my
 WordPress.org sandbox (a self-imposed prerequisite prior to committing),
 but I hadn't tested all scenarios and missed that it broke the bb's. Good
 catch, @ocean90. I didn't notice anything else, which is great.

 I want to try something here, which we've done with success before --
 putting something in trunk that has a very slim chance of making it to the
 final release, in order to get a much better idea of what it could break.
 Thus, I would be comfortable committing this to trunk in the next 7 days
 under the following conditions:
  1. We need some kind of fix or workaround (somewhere -- .org, core, or
 bb's) to avoid .org breakage. '''[ACTION NEEDED]'''
  2. We publish https://gist.github.com/jbrinley/eaaad00b52e1316c6904 on
 make/core, with some adjustments...
  3. The post should say it'll ship in 4.5, but that it is in trunk now to
 assess the extent of the damage. We should leave it in trunk for up to
 14-21 days. This would imply its removal by beta 2 or beta 3. I will
 manage the fallout. Note "up to 14-21 days" -- if the breakage is
 particularly severe, it will have to come out quickly.

 The time it spends in core will further inform how much further it has to
 go, whether it needs a significant shift in strategy, and whether it's
 possible at all.

 It's up to all of you to find success on point 1. But if that happens, I
 will handle points 2 and 3, and the commit itself.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/17817#comment:169>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform