[wp-trac] [WordPress Trac] #28633: Generate better random numbers

[WordPress Trac]

#28633: Generate better random numbers
-------------------------------------------+------------------------
 Reporter:  sarciszewski                   |       Owner:  dd32
     Type:  enhancement                    |      Status:  reviewing
 Priority:  normal                         |   Milestone:  4.4
Component:  Security                       |     Version:
 Severity:  normal                         |  Resolution:
 Keywords:  needs-testing has-patch early  |     Focuses:
-------------------------------------------+------------------------

Comment (by dd32):

 Lets see if anything breaks :)

 A few thoughts:
  * I've used `$max_random_number` which is a 32bit maximum, 64bit systems
 can achieve much greater sizes. We should update the function to handle
 64bit values on 64bit systems.
  * I've used random_compat `master` here, just for clarity over what's
 included - that is
 https://github.com/paragonie/random_compat/commit/456d84c8823207a18fb146c29f8b9e3aa0a9a31c
  * I've included no tests here, based on that `random_compat` has it's own
 set of tests

--
Ticket URL: <https://core.trac.wordpress.org/ticket/28633#comment:59>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform