[wp-trac] [WordPress Trac] #32522: Embed WordPress Posts in WordPress Posts

[WordPress Trac]

#32522: Embed WordPress Posts in WordPress Posts
------------------------------+-----------------------
 Reporter:  melchoyce         |       Owner:  pento
     Type:  enhancement       |      Status:  assigned
 Priority:  normal            |   Milestone:  4.4
Component:  Embeds            |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |     Focuses:
------------------------------+-----------------------

Comment (by pento):

 Thanks for the review, @helen!

 In [attachment:32522.6.diff]:

 * `wp-oembed.js` now passes our `jshint` rules.
 * Move the JS out of `embed-template.php`, into `wp-oembed-embed.js`, fix
 the `jshint` errors, and tweak it for optimal minifying. The resulting
 minifying reduces it from 4709 bytes to 2400 bytes.
 * Moved the CSS out of `embed-template.php, into `wp-oembed-embed.css`.
 Because we're including it inline, it has to have both the original and a
 handful of RTL rules in the same file. The resulting minifying reduces it
 from 8491 bytes to 7085 bytes.
 * Move both the CSS and JS inclusion to functions that are hooked into
 `oembed_head`.

 There are a couple of `maxwidth` tests:
 `test_get_oembed_response_data_maxwidth_too_high` and
 `test_get_oembed_response_data_maxwidth_too_low`. Was there other tests
 that you had in mind?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32522#comment:66>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform