[wp-trac] [WordPress Trac] #33830: Revisions: Compare revisions has layout issues on iPhone 6+

[WordPress Trac]

#33830: Revisions: Compare revisions has layout issues on iPhone 6+
-----------------------------------+------------------------------
 Reporter:  ryan                   |       Owner:  adamsilverstein
     Type:  defect (bug)           |      Status:  assigned
 Priority:  normal                 |   Milestone:  Awaiting Review
Component:  Revisions              |     Version:  4.3
 Severity:  normal                 |  Resolution:
 Keywords:  make-flow needs-patch  |     Focuses:  ui
-----------------------------------+------------------------------
Changes (by adamsilverstein):

 * keywords:  make-flow has-patch => make-flow needs-patch
 * owner:   => adamsilverstein
 * status:  new => assigned


Comment:

 @karine: Thanks for the patch!

 That fixes the placement of the button, yea!

 Now I see another issue: The slider gets obscured by previous/next on
 small screen:

 [[Image(http://cl.ly/image/343K3F3B171q/Revisions__sadasd__WordPress_2015-10-06_16-47-32.jpg)]]

 I see this up to medium sized screen widths, it starts to look fine around
 iphone 6 landscape size (568w) in my brief testing.

 The slider width is getting set in JS, and is clearly making some
 incorrect calculations.  I can look into that, it should work fine at a
 smaller size.

 Could we use CSS to change the next/back buttons content to icons, maybe
 arrows, below a certain breakpoint? Thinking these buttons could be even
 larger in other languages, so subbing them for icons would make sense for
 small screens.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33830#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform