[wp-trac] [WordPress Trac] #17817: do_action/apply_filters/etc. recursion on same filter kills underlying call

[WordPress Trac]

#17817: do_action/apply_filters/etc. recursion on same filter kills underlying call
-------------------------------------------------+-------------------------
 Reporter:  kernfel                              |       Owner:  nacin
     Type:  defect (bug)                         |      Status:  reviewing
 Priority:  normal                               |   Milestone:  4.4
Component:  Plugins                              |     Version:  2.2
 Severity:  normal                               |  Resolution:
 Keywords:  has-unit-tests has-patch needs-      |     Focuses:
  testing                                        |
-------------------------------------------------+-------------------------

Comment (by johnjamesjacoby):

 Replying to [comment:164 helen]:
 > Replying to [comment:163 johnjamesjacoby]:
 > > * Both BuddyPress and bbPress will need an update to match the new
 approach in WordPress core
 >
 > More concerned about back-compat here (not taking down sites that update
 core before the plugin or fail to update the plugin for whatever reason)
 and your thoughts on the approach, since you're doing deeper things with
 hooks.

 IIRC, the leads in this ticket predicted a high likelihood of breakage,
 and deemed it necessary for the sake of progress & performance. See
 [https://core.trac.wordpress.org/ticket/17817?replyto=164#comment:133 this
 comment from nacin] among others here.

 The bbs are a good litmus test for this type of breakage because they hug
 tightly to internal API's, sometimes in creative ways.  Each bb'breakage
 is a scar on their surface; a point in time where WordPress got better
 because the bb's absorbed an impact.

 Because WooCommerce and others have taken inspiration from this template-
 stack code, I'm weary of slipping it in without quickly more exposure: a
 post on Make, a clear description of why this break is necessary, and
 maybe even suggestions for alternative approaches.

 All of that said, changing this code at all scares the daylights out of
 me. Many subsystems rely on this foundation, and the bb's may have only
 helped bring attention to one specific implementation.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/17817#comment:165>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform