[wp-trac] [WordPress Trac] #22222: "Mode" buttons bumped below (in 1024x768) when long category name exists
WordPress Trac
noreply at wordpress.org
Tue Oct 6 19:09:09 UTC 2015
#22222: "Mode" buttons bumped below (in 1024x768) when long category name exists
----------------------------------------+---------------------------------
Reporter: trepmal | Owner: Oxymoron
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 4.4
Component: Posts, Post Types | Version:
Severity: minor | Resolution:
Keywords: good-first-bug needs-patch | Focuses: ui, administration
----------------------------------------+---------------------------------
Changes (by helen):
* keywords: good-first-bug dev-feedback has-patch => good-first-bug needs-
patch
Comment:
Thanks for the patch @Oxymoron. Some notes:
* All strings need to be internationalized, e.g. `<h5><?php _e( 'View
Mode' ); ?></h5>`.
* The default post types need to be everything that's not hierarchical as
it currently is (see where the current view switcher is called). So you'd
probably want to grab `get_post_types( array( 'hierarchical' => false,
'show_ui' => true ) );`
* There are a couple of whitespace changes that seem unrelated - not a big
deal, but is a little distracting when reviewing the diff. If this is
something your editor is doing, you may want to look into whether you can
set it to only clean up white space on lines you've modified.
* The changes in `wp-admin/includes/class-wp-screen.php` don't need to
break in and out of PHP quite so much :)
* Not your fault, but the Apply button probably needs to be on its own
line since it would save both of the settings above, not just the number
of items per page.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/22222#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list