[wp-trac] [WordPress Trac] #34161: PhpMailer mock decorator methods

WordPress Trac noreply at wordpress.org
Tue Oct 6 18:09:14 UTC 2015


#34161: PhpMailer mock decorator methods
------------------------------------+------------------------------
 Reporter:  welcher                 |       Owner:
     Type:  enhancement             |      Status:  new
 Priority:  normal                  |   Milestone:  Awaiting Review
Component:  Build/Test Tools        |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:
------------------------------------+------------------------------

Comment (by welcher):

 @DrewAPicture thanks for the notes.

 I'll explicitly add the public access modifiers in for sure. I can remove
 the helper methods that call the `get_address` method if that makes more
 sense from a code bloat point of view as well.

 As for the tests, I only updated one of the Unit Tests in the
 `tests/mail.php` file so there are definitely more tests in the that file
 and core in general that would benefit from these changes. I'm happy to
 update all the calls ( and probably should anyway ) to get a better sense
 of the full scope.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34161#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list