[wp-trac] [WordPress Trac] #33641: Add support for responsive images using srcset and sizes

WordPress Trac noreply at wordpress.org
Tue Oct 6 04:58:23 UTC 2015


#33641: Add support for responsive images using srcset and sizes
----------------------------+--------------------------
 Reporter:  joemcgill       |       Owner:  DH-Shredder
     Type:  task (blessed)  |      Status:  assigned
 Priority:  normal          |   Milestone:  4.4
Component:  Media           |     Version:
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:
----------------------------+--------------------------

Comment (by wonderboymusic):

 In [changeset:"34855"]:
 {{{
 #!CommitTicketReference repository="" revision="34855"
 Merge the Responsive Images feature plugin into core, initial commit. See:
 https://github.com/ResponsiveImagesCG/wp-tevko-responsive-images/

 New functions in `media.php`:
 * `wp_get_attachment_image_srcset_array()` - Returns an array of image
 candidate string data used to build a `srcset` value for an attachment
 given an `$attachement_id` and `$size`.
 * `wp_get_attachment_image_srcset()` - Returns the `srcset` value for an
 attachment given an `$attachement_id` and `$size`.
 * `wp_get_attachment_image_sizes()` - Returns the `sizes` value for an
 attachment given an `$attachement_id` and `$size` and optional arguments
 used to alter its output.
 * `wp_make_content_images_responsive()` - A display filter for adding
 `srcset` and `sizes` to images embedded in content.
 * `wp_img_add_srcset_and_sizes()` - A utility function used by
 `wp_make_content_images_responsive()` to add `srcset` and `sizes` to a
 single `<img>` element.

 Modifies existing core functions:
 * Modify `wp_get_attachment_image()` so the HTML returned for an image
 includes `srcset` and `sizes`.
 * Modify `get_media_embedded_in_content()` (sup, 3.6 leftover) by adding
 `<img>` to the list of accepted tags that can be matched in content. This
 is used in `wp_make_content_images_responsive()` to find all of the images
 embedded in content before passing them off to
 `wp_img_add_srcset_and_sizes()`.

 Tests:
 * Add a new factory method to `WP_UnitTest_Factory_For_Attachment` named
 `create_upload_object()`
 * Adds unit tests
 * Updates unit tests

 Props joemcgill, tevko, jaspermdegroot, mdmcginn, barryceelen,
 peterwilsoncc, fsylum, wonderboymusic, chriscoyier, benjaminpick, jrfnl,
 #12kingkool68, janhenckens, ryanmarkel, side777, ryelle, wturrell,
 micahmills, mattbagwell, coliff, DrewAPicture.
 See #33641.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33641#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list