[wp-trac] [WordPress Trac] #8071: Refrain from querying all the comments on a post when paged

[WordPress Trac]

#8071: Refrain from querying all the comments on a post when paged
--------------------------------------+---------------------------
 Reporter:  markjaquith               |       Owner:  boonebgorges
     Type:  enhancement               |      Status:  reopened
 Priority:  normal                    |   Milestone:  4.4
Component:  Comments                  |     Version:  2.7
 Severity:  normal                    |  Resolution:
 Keywords:  dev-feedback needs-patch  |     Focuses:
--------------------------------------+---------------------------
Changes (by boonebgorges):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 @smerriman - Thanks for your comment. I don't have a lot of sympathy for
 themes that don't have comment pagination built in - this should be a
 basic feature of any them. But I am sympathetic to sites that will
 suddenly have the behavior of their sites changed in a radical way. And
 thinking it over, I see that comment permalinks will be affected fairly
 broadly by this change, since comment-page-x is part of comment
 permalinks, and forcing pagination is going to move some comments to
 secondary pages.

 One of the pillars of this ticket is that we must force pagination at some
 point. Originally, wonderboymusic had suggested that we set a threshold
 higher than comments_per_page. In working on the patch, I decided that
 forced pagination made the 'page_comments' setting pointless, so I pulled
 it out. But in retrospect, the problems described above suggest that we
 should be much more delicate about forcing pagination. I think I'd like to
 reintroduce page_comments, and continue to respect it, until we get to a
 fairly high threshold - maybe 250 or 500 - at which point we'll force
 pagination.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/8071#comment:55>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform