[wp-trac] [WordPress Trac] #33641: Add support for responsive images using srcset and sizes

WordPress Trac noreply at wordpress.org
Mon Oct 5 16:38:25 UTC 2015


#33641: Add support for responsive images using srcset and sizes
----------------------------+--------------------------
 Reporter:  joemcgill       |       Owner:  DH-Shredder
     Type:  task (blessed)  |      Status:  assigned
 Priority:  normal          |   Milestone:  4.4
Component:  Media           |     Version:
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:
----------------------------+--------------------------

Comment (by DrewAPicture):

 Added [attachment:33641.2.patch] which includes some docs and coding
 standards adjustments.

 Notable stuff:

 * Adding backticks in inline comments is moot because they aren't parsed
 * Added a changelog entry for the
 `media_embedded_in_content_allowed_types` hook
 * Updated the version on the `wp_image_sizes_args` hook (safe to assume
 2.4.0 is the version of the plugin)
 * In a couple of functions, I renamed the `$id` parameter to
 `$attachment_id` for self-documentation purposes
 * Some spacing and syntax in various places.

 Overall, this is extremely well-documented. Nice work.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33641#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list