[wp-trac] [WordPress Trac] #31130: WP_INSTALLING causes leakage between unit tests

[WordPress Trac]

#31130: WP_INSTALLING causes leakage between unit tests
------------------------------------+---------------------------
 Reporter:  boonebgorges            |       Owner:  boonebgorges
     Type:  defect (bug)            |      Status:  assigned
 Priority:  normal                  |   Milestone:  4.4
Component:  Build/Test Tools        |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:
------------------------------------+---------------------------

Comment (by jeremyfelt):

 Replying to [comment:18 boonebgorges]:
 > Again, I'm not opposed to a more general approach to the use of
 constants, but `WP_INSTALLING` is more of an internal tool which is a
 constant by technical necessity, than it is a "config" setting. A
 standalone solution seems prudent.

 Agree completely.

 [https://core.trac.wordpress.org/attachment/ticket/31130/31130.3.diff
 31130.3.diff] is a refresh of 31330.2.diff. Some recent churn confused
 things a bit. I also had to add DB error suppression in
 `test_current_user_can_for_blog()` for the one check against a non-
 existent site. I'm not entirely sure why this was causing DB error output
 after patch and not before, but that's one of the reasons we're in this
 ticket... :)

 With this patch:

 * All standard, multisite, and ajax tests pass locally.
 * I was able to install WordPress from scratch.
 * I was able to create a network.
 * I was able to add a new site to the network.

 I like it.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31130#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform