[wp-trac] [WordPress Trac] #32286: How do I change my profile picture?

WordPress Trac noreply at wordpress.org
Sun Oct 4 14:10:50 UTC 2015


#32286: How do I change my profile picture?
--------------------------------------+-----------------------------
 Reporter:  iseulde                   |       Owner:
     Type:  defect (bug)              |      Status:  new
 Priority:  normal                    |   Milestone:  Future Release
Component:  Users                     |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  good-first-bug has-patch  |     Focuses:
--------------------------------------+-----------------------------

Comment (by carolinegeven):

 Replying to [comment:4 iCaleb]:
 > I like this a lot. I've been asked quite a few times how to set a
 profile picture, and we definitely cannot assume that a user will just
 *know* that they should go to gravatar.com.
 >
 > I'm in favor of the second patch, 32286-form.diff. However, what would
 be the harm in displaying this for all users on the site? I don't think a
 `IS_PROFILE_PAGE` check may be necessary.
 >
 > And then I'm not good at translation functions, but I think the sprintf
 and printf could be merged perhaps?

 Thanks! I appreciate the feedback!

 The check isn't necessary, you're right about that. The reason I decided
 on the `IS_PROFILE_PAGE `check, is because only the user him/herself can
 change their profile pic on Gravatar. As a super admin, I wouldn't be able
 to change the profile picture for someone else. If people prefer to always
 display that, then I'm all for that too.

 The reason I seperared the printf and sprintf, is for readability. That
 can be merged should that be the preferred way!

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32286#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list