[wp-trac] [WordPress Trac] #34140: WP_Customize_Setting::update( $value ) bad return value

WordPress Trac noreply at wordpress.org
Sat Oct 3 22:25:27 UTC 2015


#34140: WP_Customize_Setting::update( $value ) bad return value
--------------------------+-----------------------------
 Reporter:  wpweaver      |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Customize     |    Version:  4.3.1
 Severity:  normal        |   Keywords:
  Focuses:                |
--------------------------+-----------------------------
 The update function seems to need to return a value to get the Save &
 Publish button to change to Saved (I'm guessing).

 At any rate, the default: case has:


 {{{
 return do_action( 'customize_update_' . $this->type, $value, $this );
 }}}

 The problem is that do_action does not return a value. This failure makes
 it impossible to save options with a custom setting type using preview.
 And as noted in another ticket, preview is seriously broken with the
 order(N(squared)) issue.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34140>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list