[wp-trac] [WordPress Trac] #33735: Reduce Duplication and Improve Comment Notification Email Functions

[WordPress Trac]

#33735: Reduce Duplication and Improve Comment Notification Email Functions
--------------------------------------+------------------
 Reporter:  dshanske                  |       Owner:
     Type:  enhancement               |      Status:  new
 Priority:  low                       |   Milestone:  4.4
Component:  Comments                  |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  good-first-bug has-patch  |     Focuses:
--------------------------------------+------------------

Comment (by SergeyBiryukov):

 Unfortunately, `sprintf( __( 'New %1s on your post "%2s"' ),
 get_comment_type( $comment_id ), ... )` is not translatable, see
 [comment:ticket:17609:3] and [comment:ticket:19099:1]. The comment type
 should remain in the string.

 Same for `sprintf( __( 'You can see all %s on this post here:' ),
 get_comment_type( $comment_id ) )`.

 Perhaps moving `switch ( $comment->comment_type )` with the corresponding
 strings to `get_comment_notify_text()` would work.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33735#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform