[wp-trac] [WordPress Trac] #28290: Changing _site_option functions for _network_option functions

[WordPress Trac]

#28290: Changing _site_option functions for _network_option functions
------------------------------------+-------------------------
 Reporter:  jmlapam                 |       Owner:  jeremyfelt
     Type:  enhancement             |      Status:  reviewing
 Priority:  normal                  |   Milestone:  4.4
Component:  Options, Meta APIs      |     Version:  4.0
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:  multisite
------------------------------------+-------------------------

Comment (by jeremyfelt):

 [https://core.trac.wordpress.org/attachment/ticket/28290/28290.2.diff
 28290.2.diff] uses `global $current_site` instead of `get_current_site()`
 as `ms-settings.php` calls `get_current_site()` before `ms-functions.php`
 has been loaded. I'll need to document the new global use pre-commit as
 well. Multisite tests are passing fine locally.

 Replying to [comment:28 DrewAPicture]:
 > FYI: A new filter on the expiration for "site" transients is being
 proposed in #21330. I'm tempted to recommend holding up introducing that
 new filter until we have a resolution here, hopefully in 4.4.

 My initial reaction is that we'll probably want to leave the naming of the
 transient functions alone as they don't have a great way to change the
 cache key to match the network yet. That will probably need to be part of
 a future ticket, so you may be okay to add the filter as needed now.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/28290#comment:31>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform