[wp-trac] [WordPress Trac] #22993: Admin - users without a role are difficult to find

[WordPress Trac]

#22993: Admin - users without a role are difficult to find
----------------------------------------+---------------------------------
 Reporter:  logikal16                   |       Owner:  johnbillion
     Type:  defect (bug)                |      Status:  assigned
 Priority:  normal                      |   Milestone:  4.4
Component:  Users                       |     Version:  3.5
 Severity:  normal                      |  Resolution:
 Keywords:  has-patch needs-unit-tests  |     Focuses:  ui, administration
----------------------------------------+---------------------------------
Changes (by johnbillion):

 * keywords:  ux-feedback needs-refresh => has-patch needs-unit-tests
 * owner:   => johnbillion
 * status:  new => assigned
 * milestone:  Awaiting Review => 4.4


Comment:

 [attachment:22993.3.diff] addresses this and is based on the patch from
 spmlucas.

 The main difference is that it modifies the `count_users()` function so it
 also counts the number of users with no role. This means that no extra
 database queries are added to the Users screen by default, and the
 potentially expensive `wp_get_norole_users()` function is only called when
 the user clicks the 'No role' filter.

 This needs unit tests for `wp_get_norole_users()` and `count_users()`, and
 some comprehensive testing on multisite. Also the `wp_get_norole_users()`
 function needs a better name.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/22993#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform