[wp-trac] [WordPress Trac] #34073: Comment walker calls get_comment_link with invalid arguments

[WordPress Trac]

#34073: Comment walker calls get_comment_link with invalid arguments
-------------------------------------+---------------------------
 Reporter:  peterwilsoncc            |       Owner:  boonebgorges
     Type:  defect (bug)             |      Status:  assigned
 Priority:  normal                   |   Milestone:  4.4
Component:  Comments                 |     Version:  trunk
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+---------------------------

Comment (by boonebgorges):

 In [changeset:"34729"]:
 {{{
 #!CommitTicketReference repository="" revision="34729"
 Simplify pagination logic in `comments_template()`.

 [34561] "fixed" the problem of newest-first comments showing fewer than
 'per_page' comments on the post permalink when the total number of
 comments
 was not divisible by 'per_page'. See #29462. But this fix caused numerous
 other problems. First, comment pages reported by `get_page_of_comment()`
 (which expects comment pages to be filled oldest-first) were no longer
 correct.
 Second, and more seriously, the new logic caused comments to be shifted
 between pages, making their permalinks non-permanent.

 The current changeset reverts the changed behavior. In order to preserve
 the
 performance improvements introduced in [34561], an additional query must
 be
 performed when 'default_comments_page=newest' and 'cpage=0' (ie, you're
 viewing
 the post permalink). A nice side effect of this revert is that we no
 longer
 need the hacks required to determine proper comment pagination, introduced
 in
 [34561].

 See #8071. See #34073.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34073#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform