[wp-trac] [WordPress Trac] #34808: Deprecate get_media_embedded_in_content() and get_tag_regex()

WordPress Trac noreply at wordpress.org
Sat Nov 28 05:11:26 UTC 2015


#34808: Deprecate get_media_embedded_in_content() and get_tag_regex()
-------------------------------+-----------------------------
 Reporter:  azaozz             |       Owner:
     Type:  defect (bug)       |      Status:  new
 Priority:  normal             |   Milestone:  Future Release
Component:  Posts, Post Types  |     Version:
 Severity:  normal             |  Resolution:
 Keywords:                     |     Focuses:
-------------------------------+-----------------------------
Description changed by azaozz:

Old description:

> Both are "dead" functions not used anywhere in core. Seem like left overs
> from the post types code in 3.6.
>
> `get_media_embedded_in_content()` is buggy: cannot handle nested
> `<object>` tags (which were popular few years ago for flash movies) and
> doesn't match short ended tags without a backslash at the end.
>
> `get_tag_regex()` is buggy too, see #26674. It was used in
> `get_media_embedded_in_content()` before [31574]. Not used anywhere since
> then.

New description:

 Both are "dead" functions not used anywhere in core. Seem like left overs
 from the post types code in 3.6.

 `get_media_embedded_in_content()` is buggy: cannot handle nested
 `<object>` tags (which were popular few years ago for embedding flash) and
 doesn't match short ended tags without a slash at the end.

 `get_tag_regex()` is also buggy, see #26674. It was used in
 `get_media_embedded_in_content()` before [31574]. Not used anywhere since
 then.

--

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34808#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list