[wp-trac] [WordPress Trac] #34795: Media: missing trash when MEDIA_TRASH set to true

[WordPress Trac]

#34795: Media: missing trash when MEDIA_TRASH set to true
--------------------------+-----------------------------------------
 Reporter:  afercia       |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  4.4
Component:  Media         |    Version:  trunk
 Severity:  normal        |   Keywords:  needs-patch has-screenshots
  Focuses:  ui            |
--------------------------+-----------------------------------------
 Enable the Media trash in your `wp-config.php`
 {{{
 define( 'MEDIA_TRASH', true );
 }}}
 - go in the Media Library > List mode
 - trash an attachment
 - the "Trash" option is missing in the Filter select, see screenshot below

 [[Image(https://cldup.com/mm8KL60tFh.png)]]

 As far as I see, introduced in [34256] since `$this->is_trash` is always
 false except when explicitly requesting for `attachment-filter=trash`.

 So, the "Trash" option appears just... in the Trash view. In all the other
 views (All, Images, Audio, etc.) there's the need to check for something
 else. Previously, there was a check to count the trashed items.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34795>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform