[wp-trac] [WordPress Trac] #34164: Error during installation at step 1 - Undefined index: host

[WordPress Trac]

#34164: Error during installation at step 1 - Undefined index: host
----------------------------------------+-----------------------------
 Reporter:  jlambe                      |       Owner:
     Type:  defect (bug)                |      Status:  new
 Priority:  normal                      |   Milestone:  Future Release
Component:  Upgrade/Install             |     Version:  4.0
 Severity:  normal                      |  Resolution:
 Keywords:  needs-patch good-first-bug  |     Focuses:
----------------------------------------+-----------------------------
Changes (by jeremyfelt):

 * keywords:  reporter-feedback => needs-patch good-first-bug
 * version:   => 4.0
 * milestone:  Awaiting Review => Future Release


Comment:

 Thanks for the additional info. I'm able to replicate this as well, not
 sure why the notice wasn't showing before.

 When another language is selected during installation, an HTTP request is
 made to retrieve the language pack. In `wp_http_validate_url()` we check
 the host of the URL against the host of the current site to see if it an
 external request that requires additional validation. We don't take
 currently take into consideration that no host has been set for the
 current site yet, so that comparison generates a notice.

 A similar issue was fixed via #28648 in [28865]. We should treat this
 similarly and mark the URL as an external host if no host has yet been
 set.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34164#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform