[wp-trac] [WordPress Trac] #34772: get_contents won't unlink tempfile when ftp_fget returns false

[WordPress Trac]

#34772: get_contents won't unlink tempfile when ftp_fget returns false
------------------------------+-----------------------------
 Reporter:  ruud@…            |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  Future Release
Component:  Filesystem API    |     Version:  4.3.1
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |     Focuses:
------------------------------+-----------------------------
Changes (by dd32):

 * keywords:  has-patch commit dev-feedback => has-patch commit


Comment:

 In 4.4+ `wp_tempnam()` includes some random data per-call into the
 filename, which should greatly reduce the chances of it hitting a
 conflicting filename.

 Theoretically servers shouldn't be hitting this code branch too often, if
 it is, there's likely something else wrong with the server which needs to
 be investigated.. but that being said, this patch is definitely good, the
 only reason I didn't commit it immediately was we were about to go RC1 for
 4.4.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34772#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform