[wp-trac] [WordPress Trac] #34306: Twenty Sixteen as default theme

[WordPress Trac]

#34306: Twenty Sixteen as default theme
----------------------------+-----------------------
 Reporter:  SergeyBiryukov  |       Owner:
     Type:  task (blessed)  |      Status:  assigned
 Priority:  normal          |   Milestone:  4.4
Component:  Bundled Theme   |     Version:
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:
----------------------------+-----------------------

Comment (by jeremyfelt):

 I think the `CORE_UPGRADE_SKIP_NEW_BUNDLED` handling in
 [attachment:34306.3.diff] makes sense. I've updated that patch in
 [attachment:34306.4.diff] with a syntax error fix - `:` vs  `;`.

 Replying to [comment:8 nacin]:
 > In the case of `populate_options()` (for an initial blog), we can simply
 instantiate the site with `WP_DEFAULT_THEME` — which is what we already
 did previously when the theme didn't exist (we didn't check). This would
 only really come into play in multisite.

 The change in behavior here is that previously, if the theme defined in
 `WP_DEFAULT_THEME` was not available, it would still be set as the theme
 for a new site, which would then effectively not have a theme. Now, if
 `WP_DEFAULT_THEME` is not available, and a core theme exists, that will
 automatically be activated. I don't think that's a bad change. Any network
 that wants to restrict new sites from using core themes should make sure
 their default theme exists. :)

 > I think it's past the point where we add UI to set a network default
 theme. Before then, should we possibly choose a theme that is "allowed"
 for the network, since we can presume those exist?

 Agreed. We should look at adding this in the near future. I don't think we
 should rush into choosing an "allowed" theme as there are often going to
 be many for a single network. Do you take the first/last/random and
 activate that? I'd rather  leave it for the network admin to decide until
 we have a better UI in place.

 I haven't tested any updates using the patch, but I have gone through the
 process of creating a new network and sites on that network a few times
 and things seem stable/sane.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34306#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform