[wp-trac] [WordPress Trac] #33413: most PHP classes should be in their own file
WordPress Trac
noreply at wordpress.org
Mon Nov 23 17:06:48 UTC 2015
#33413: most PHP classes should be in their own file
----------------------------+-----------------------------
Reporter: wonderboymusic | Owner: wonderboymusic
Type: enhancement | Status: reopened
Priority: normal | Milestone: 4.4
Component: General | Version: trunk
Severity: normal | Resolution:
Keywords: dev-feedback | Focuses:
----------------------------+-----------------------------
Changes (by nerrad):
* status: closed => reopened
* resolution: fixed =>
Comment:
r35718 causes a fatal for our use case. We extend
Walker_Category_Checklist to create a Walker_Radio_Checklist class and
before extending we had this require:
{{{
require_once ABSPATH . 'wp-admin/includes/template.php';
}}}
prior to r35718 the backward compat added by @wonderboymusic took care of
the require. But r35718 not only breaks but causes fatals. Easy fix, but
it does seem to be the kind of thing that other developers might run into.
I agree with @danielbachhuber that making this kind of adjustment so close
to RC is kind of hairy.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/33413#comment:125>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list