[wp-trac] [WordPress Trac] #32802: Update Masonry (v3.3.2) & imagesLoaded (v3.2.0) package

[WordPress Trac]

#32802: Update Masonry (v3.3.2) & imagesLoaded (v3.2.0) package
-------------------------------------------------+-------------------------
 Reporter:  Ninos Ego                            |       Owner:
     Type:  enhancement                          |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
Component:  External Libraries                   |  Review
 Severity:  normal                               |     Version:  4.3
 Keywords:  needs-testing needs-codex dev-       |  Resolution:
  feedback has-patch                             |     Focuses:  javascript
-------------------------------------------------+-------------------------

Comment (by grapplerulrich):

 I do not have commit access but I have experience with contributing to WP.
 By only fixing one thing in a ticket makes it move faster normally.

 The `jquery-masonry` handle needs to stay in WP core with the shiv for
 backwards compatibility.

 I think it was a mistake to include imagesLoaded within the masonry file.

 It would be good to check how many themes are using imagesloaded when
 using the masonry handle.


 {{{
 // Masonry v2 depended on jQuery. v3 does not. The older jquery-masonry
 handle is a shiv.
 // It sets jQuery as a dependency, as the theme may have been implicitly
 loading it this way.
 $scripts->add( 'masonry', "/wp-includes/js/masonry.min.js", array(),
 '3.3.2', 1 );
 $scripts->add( 'imagesloaded', "/wp-includes/js/imagesloaded.min.js",
 array(), '3.2.0', 1 );
 $scripts->add( 'jquery-masonry', "/wp-
 includes/js/jquery/jquery.masonry$dev_suffix.js", array( 'jquery',
 'masonry', 'imagesloaded' ), '3.3.2', 1 );
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32802#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform