[wp-trac] [WordPress Trac] #33885: meta_form performs a potentially expensive query

[WordPress Trac]

#33885: meta_form performs a potentially expensive query
-------------------------------------+-----------------------------
 Reporter:  jorbin                   |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  Future Release
Component:  Administration           |     Version:  4.3.1
 Severity:  critical                 |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  performance
-------------------------------------+-----------------------------

Comment (by nacin):

 So this is pretty terrible.

 Really what I'd like to do here is just kill the damn meta box. Perhaps in
 4.5 we can try to nuke it for all new installs.

 If a site is affected, and they would like to use this filter, can't they
 just instead remove the meta box entirely? What's the need for the filter,
 in that case? The venn diagram of (1) sites that will apply this filter
 and (2) sites that use custom fields is, I'm pretty sure, just wired.com
 (per @tollmanz, who like @helen is sitting next to me at php[world]). As a
 workaround, they could either intercept the query, copy-paste the meta
 box, or build a better user experience. I will lose zero sleep over this
 very rare situation. Thanks @helen for getting me riled up about this.

 But if we're going to do the filter, let's have it be `null` by default,
 that way someone can return an empty array.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33885#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform