[wp-trac] [WordPress Trac] #34698: HTML-Embed code JavaScript error.

[WordPress Trac]

#34698: HTML-Embed code JavaScript error.
-------------------------------------------------+-------------------------
 Reporter:  nendeb55                             |       Owner:  swissspidy
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  4.4
Component:  Embeds                               |     Version:  trunk
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch dev-feedback needs-unit-   |     Focuses:
  tests                                          |
-------------------------------------------------+-------------------------

Comment (by peterwilsoncc):

 Replying to [comment:12 nendeb55]:
 > Does get_post_embed_html(), too?
 It does, yes.

 ~

 I'm stuck on ensuring uglify doesn't re-introduce the `&&` back in to the
 compressed code.

 Most reliable method going forward seems to be to stop uglify optimising
 the if/for loops in this file. Reversing the logic worked in a couple of
 instances `(!(x!=y||z!=y))` but it's not as future friendly as a custom
 build.

 Any suggestions from the build tools team would be grand :)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34698#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform