[wp-trac] [WordPress Trac] #5172: Adding classes to wp_generate_tag_cloud

WordPress Trac noreply at wordpress.org
Mon Nov 16 19:08:07 UTC 2015


#5172: Adding classes to wp_generate_tag_cloud
---------------------------+-----------------------------
 Reporter:  chmac          |       Owner:
     Type:  enhancement    |      Status:  assigned
 Priority:  normal         |   Milestone:  Future Release
Component:  Taxonomy       |     Version:
 Severity:  normal         |  Resolution:
 Keywords:  needs-refresh  |     Focuses:  template
---------------------------+-----------------------------
Changes (by boonebgorges):

 * keywords:  reporter-feedback dev-feedback has-patch => needs-refresh


Comment:

 The idea behind classes suggested in the patch looks good to me, but the
 patch needs a refresh after [32996].

 `'tag-cloud-item-' . count( $a )` feels like a weird class name. The
 integer doesn't describe the item, it describes the cardinal position (1,
 2, 3...) of the tag in the cloud. How about `'tag-cloud-item-position-'`?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/5172#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list