[wp-trac] [WordPress Trac] #34359: Cache output of `wp_upload_dir()` to improve performance

[WordPress Trac]

#34359: Cache output of `wp_upload_dir()` to improve performance
-------------------------------------------------+-------------------------
 Reporter:  DH-Shredder                          |       Owner:  DH-
     Type:  defect (bug)                         |  Shredder
 Priority:  normal                               |      Status:  assigned
Component:  Media                                |   Milestone:  4.4
 Severity:  normal                               |     Version:
 Keywords:  has-patch needs-testing needs-unit-  |  Resolution:
  tests                                          |     Focuses:  multisite,
                                                 |  performance
-------------------------------------------------+-------------------------

Comment (by DH-Shredder):

 @azaozz Thanks for writing this up!

 I think that this late in the release, it's unwise to push a change like
 this to persistent cache.

 I'd still support a change that only caches it per page/WordPress-load, in
 a static variable, or otherwise, but think we should be careful when it
 comes to persistent cache.

 One things that stands out at first is that, unless I'm missing it, it
 doesn't seem to cache per blog ID.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34359#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform