[wp-trac] [WordPress Trac] #34640: Twemoji fallback doesn't kick in on subsequent DOM mutations

[WordPress Trac]

#34640: Twemoji fallback doesn't kick in on subsequent DOM mutations
-----------------------------------+-------------------------
 Reporter:  rmccue                 |       Owner:  pento
     Type:  defect (bug)           |      Status:  assigned
 Priority:  normal                 |   Milestone:  4.4
Component:  General                |     Version:  4.2
 Severity:  normal                 |  Resolution:
 Keywords:  2nd-opinion has-patch  |     Focuses:  javascript
-----------------------------------+-------------------------

Comment (by pento):

 @iseulde: Good idea, I've revised the patch so that `onerror` is now an
 option - we can easily contribute that back upstream.

 Unfortunately, we need to keep several of the checks in that conditional
 (need to make sure `removedNodes[0]` will be defined, and that `nodeName
 === 'IMG'`, because text nodes don't have the `getAttribute()` method. I
 just left the conditional the same in [attachment:34640.2.diff], but if
 you're comfortable removing some of the checks, I'm cool with that.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34640#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform