[wp-trac] [WordPress Trac] #29974: Focus handle at wrong place when you click reply
WordPress Trac
noreply at wordpress.org
Tue Nov 10 18:33:08 UTC 2015
#29974: Focus handle at wrong place when you click reply
-------------------------------------+-------------------------------------
Reporter: nhuja | Owner: afercia
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 4.4
Component: Comments | Version: 2.7
Severity: normal | Resolution:
Keywords: has-patch has- | Focuses: accessibility,
screenshots | javascript
-------------------------------------+-------------------------------------
Comment (by afercia):
Refreshed patch, trying to simplify a bit and improve checking for
visibility that fails in some edge cases, see for example:
http://s.codepen.io/afercia/debug/YyRpzw
* extends support to IE 8
* no need for a `while` loop to recursively check the parent nodes
* improves checking for elements hidden with CSS:
* for visibility: `getComputedStyle()` / `currentStyle` already return
the actual computed value, taking into account the ancestors visibility
(doesn't work in IE 7-)
* for display none: do the same thing jQuery does, checking for
`offsetWidth` and `offsetHeight`
Would greatly appreciate feedback and JavaScript review :)
--
Ticket URL: <https://core.trac.wordpress.org/ticket/29974#comment:60>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list