[wp-trac] [WordPress Trac] #34561: Abstract some embed template code into functions

[WordPress Trac]

#34561: Abstract some embed template code into functions
-------------------------+--------------------
 Reporter:  johnbillion  |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  4.4
Component:  Embeds       |     Version:  trunk
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:
-------------------------+--------------------
Changes (by swissspidy):

 * keywords:  has-patch dev-feedback => has-patch


Comment:

 > I don't think that the_embed_footer should print the share button, since
 we can remove_filter on print_embed_sharing_dialog if i don't want this
 embed to be shared.

 That makes sense, but we should print the comments button similarly. Note
 that there's already the `embed_content_meta` hook we can use here.

 [attachment:34561.5.diff] leverages this hook with two new functions:
 `print_embed_sharing_button` and `print_embed_comments_button`.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34561#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform