[wp-trac] [WordPress Trac] #34109: Incorrect URL scheme for media in the admin area when using administration over HTTPS

[WordPress Trac]

#34109: Incorrect URL scheme for media in the admin area when using administration
over HTTPS
------------------------------------------------+--------------------------
 Reporter:  johnbillion                         |       Owner:
     Type:  defect (bug)                        |      Status:  new
 Priority:  normal                              |   Milestone:  Awaiting
Component:  Media                               |  Review
 Severity:  major                               |     Version:
 Keywords:  needs-patch needs-unit-tests https  |  Resolution:
                                                |     Focuses:
                                                |  administration
------------------------------------------------+--------------------------

Comment (by joemcgill):

 > It's likely that altering the behaviour of wp_get_attachment_url() will
 have unintended consequences (as above)

 The post editor actually uses a separate function, `get_image_tag()` to
 generate the HTML for images inserted into posts, so it may be safe to
 alter `wp_get_attachment_image()` so that it generates a tag using the
 correct scheme as long as we also add a check in `get_image_tag()` to only
 use an HTTPS scheme when the uploads directory is using HTTPS as the
 scheme.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34109#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform