[wp-trac] [WordPress Trac] #34612: Responsive Images: Make new function/filter signatures more consistent
WordPress Trac
noreply at wordpress.org
Mon Nov 9 19:46:04 UTC 2015
#34612: Responsive Images: Make new function/filter signatures more consistent
--------------------------+---------------------
Reporter: joemcgill | Owner: azaozz
Type: defect (bug) | Status: closed
Priority: normal | Milestone: 4.4
Component: Media | Version:
Severity: normal | Resolution: fixed
Keywords: has-patch | Focuses:
--------------------------+---------------------
Changes (by DrewAPicture):
* keywords: has-patch commit => has-patch
Comment:
Replying to [comment:4 joemcgill]:
> Looks like I missed updating the params for `wp_calculate_image_srcset`
filter in [attachment:34612.diff]. I've uploaded
[attachment:34612.filter.diff], which corrects the param order and adds
`$image_src` to the filter. Inline docs are updated as well.
We're going to have to move the code example into the hook doc
description. As-is, it would be read as a sentence with the extra spaces
removed. So let's move it to the description, four-space indented and
figure out a good way to refer back to it from the parameter description.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/34612#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list