[wp-trac] [WordPress Trac] #34617: Add filter for shiny updates

WordPress Trac noreply at wordpress.org
Mon Nov 9 05:37:18 UTC 2015


#34617: Add filter for shiny updates
-----------------------------+------------------------------
 Reporter:  afragen          |       Owner:
     Type:  enhancement      |      Status:  new
 Priority:  normal           |   Milestone:  Awaiting Review
Component:  Upgrade/Install  |     Version:  trunk
 Severity:  normal           |  Resolution:
 Keywords:  has-patch close  |     Focuses:
-----------------------------+------------------------------
Changes (by dd32):

 * keywords:  has-patch => has-patch close


Comment:

 > An $upgrader_instance isn't passed to this filter.

 My proposal was to add it, however that can't be done until #27365 is
 resolved.

 I still think your approach is wrong, I don't think there's really much
 that we should do to support it. Another way could be to extend
 `Plugin_Upgrader` and do it that way, but that'd also require you to jump
 through hoops.

 `WP_Upgrader` really doesn't like packages that aren't in it's expected
 format..

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34617#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list