[wp-trac] [WordPress Trac] #34617: Add filter for shiny updates

[WordPress Trac]

#34617: Add filter for shiny updates
-----------------------------+------------------------------
 Reporter:  afragen          |       Owner:
     Type:  enhancement      |      Status:  new
 Priority:  normal           |   Milestone:  Awaiting Review
Component:  Upgrade/Install  |     Version:  trunk
 Severity:  normal           |  Resolution:
 Keywords:  has-patch        |     Focuses:
-----------------------------+------------------------------

Comment (by afragen):

 Replying to [comment:8 dd32]:
 > > Did I miss an existing filter?
 >
 > Nope, my point was that it's supposed to happen transparently, so that
 no filtering is needed.
 >
 > I'll take a look into this today, I have a few ideas on how to approach
 it.

 It probably would happen transparently if I weren't renaming the
 destination directory.

 Let me explain what happens. The plugin updates from GitHub source and
 downloads as `user-repo-hash`, instead of just `repo`. I use the
 `upgrader_post_install` filter to rename to `repo` but in shiny updates
 the referenced function gets the original destination and passes it.
 Because of this the new, updated plugin location isn't referenced and
 later in that function the `get_plugins` call is to the original location
 that doesn't exist.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34617#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform