[wp-trac] [WordPress Trac] #32812: Customizer Menus: Escaping inconsistencies

[WordPress Trac]

#32812: Customizer Menus: Escaping inconsistencies
--------------------------+--------------------------
 Reporter:  swissspidy    |       Owner:  westonruter
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:  4.4
Component:  Customize     |     Version:  4.3
 Severity:  normal        |  Resolution:  fixed
 Keywords:  has-patch     |     Focuses:
--------------------------+--------------------------
Changes (by westonruter):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"35580"]:
 {{{
 #!CommitTicketReference repository="" revision="35580"
 Customize: Improve alignment of
 `WP_Customize_Nav_Menu_Item_Setting::sanitize()` behavior with
 `wp_update_nav_menu_item()`.

 * Apply `title_save_pre`, `excerpt_save_pre`, and `content_save_pre`
 filters on a nav menu item's `title`, `attr_title`, and `description`
 properties respectively. This ensures that arbitrary markup can be
 supplied if the user has `unfiltered_html` cap, and for these fields to
 have markup stripped if not.
 * Ensure a nav menu item's `post_status` is sanitized as `publish` or
 `draft` using the same conditions as `wp_update_nav_menu_item()`.
 * Align `WP_Customize_Nav_Menu_Item_Setting::sanitize()` behavior for
 sanitizing `position` to be the same as `wp_update_nav_menu_item()`.
 * Also apply `nav_menu_attr_title` and `nav_menu_description` filters in
 `WP_Customize_Nav_Menu_Item_Setting::value_as_wp_post_nav_menu_item()` to
 ensure that previewing markup entered into menu item description will
 preview the same way as when the nav menu item is saved.
 * Add unit tests.

 Fixes #32812.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32812#comment:29>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform