[wp-trac] [WordPress Trac] #29257: media_sideload_image() calls rename() on temp file, which can break streams

[WordPress Trac]

#29257: media_sideload_image() calls rename() on temp file, which can break streams
--------------------------+---------------------
 Reporter:  joehoyle      |       Owner:  dd32
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:  4.4
Component:  Media         |     Version:  3.9.2
 Severity:  normal        |  Resolution:  fixed
 Keywords:  has-patch     |     Focuses:
--------------------------+---------------------
Changes (by dd32):

 * status:  reviewing => closed
 * resolution:   => fixed


Comment:

 In [changeset:"35579"]:
 {{{
 #!CommitTicketReference repository="" revision="35579"
 Media: Allow `media_sideload_image()` to work when the upload directory is
 a PHP Stream. Using copy() instead of rename() allows the function to work
 across different stream sources.
 Props mattheu.
 Fixes #29257
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29257#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform