[wp-trac] [WordPress Trac] #34617: Add filter for shiny updates

[WordPress Trac]

#34617: Add filter for shiny updates
-----------------------------+------------------------------
 Reporter:  afragen          |       Owner:
     Type:  enhancement      |      Status:  new
 Priority:  normal           |   Milestone:  Awaiting Review
Component:  Upgrade/Install  |     Version:  trunk
 Severity:  normal           |  Resolution:
 Keywords:  has-patch        |     Focuses:
-----------------------------+------------------------------

Comment (by afragen):

 Replying to [comment:4 dd32]:
 > > If plugin updates are done via shiny updates the version info won't be
 found as the $result in wp_ajax_update_plugin() is looking in a
 destination that has been renamed.
 >
 > This use-case should be fixed through the existing code, rather than
 through a filter. I say this as it's supported in the standard code, and I
 thought I'd tested it as working (but evidently not).
 >
 > What would be another use-case for this potential filter?

 There's no ability to fix this through existing code as the renaming
 occurs in either the `upgrader_post_install` or
 `upgrader_source_selection` filter(s).

 In the referenced function `wp_ajax_update_plugin()` a new
 `Plugin_Upgrader` instance is created and the `$upgrade->bulk_upgrade()`
 doesn't seem to have a filter for it's return value.

 If there's a filter available to modify the results of this function I'm
 not sure what it is.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34617#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform