[wp-trac] [WordPress Trac] #34561: Abstract some embed template code into functions

[WordPress Trac]

#34561: Abstract some embed template code into functions
------------------------------------+--------------------
 Reporter:  johnbillion             |       Owner:
     Type:  enhancement             |      Status:  new
 Priority:  normal                  |   Milestone:  4.4
Component:  Embeds                  |     Version:  trunk
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:
------------------------------------+--------------------

Comment (by swissspidy):

 Replying to [comment:4 juliobox]:
 > Please try to keep consistency between function names
 > *_embed() OR the_embed_*() OR embed_*()
 > and not a mix of that, thanks :)

 `the_footer_embed` or `the_header_embed` sound strange though and there's
 no equivalent function without this suffix (whereas `the_excerpt_embed` is
 the equivalent to `the_excerpt()`). It makes sense to use the `the_`
 prefix, as these are template tags meant to be used to ''echo'' data in
 theme templates.

 ----

 Anyway, it's a minor point. I'm more wondering if the overall approach
 seems reasonable. After that we can still change function names.

 @johnbillion any opinion on the current patch?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34561#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform