[wp-trac] [WordPress Trac] #34612: Responsive Images: Make new function/filter signatures more consistent

[WordPress Trac]

#34612: Responsive Images: Make new function/filter signatures more consistent
--------------------------+-----------------------
 Reporter:  joemcgill     |       Owner:  azaozz
     Type:  defect (bug)  |      Status:  assigned
 Priority:  normal        |   Milestone:  4.4
Component:  Media         |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+-----------------------
Changes (by joemcgill):

 * owner:   => azaozz
 * status:  new => assigned


Comment:

 [attachment:34612.diff] moves the logic of
 `wp_get_attachment_image_sizes()` to `wp_calculate_image_sizes()` and
 renames the filter `wp_calculate_image_sizes()`. The parameter order now
 matches the order or params in `wp_calculate_image_srcset()`.

 The previous function name: `wp_get_attachment_image_sizes()` now accepts
 an attachment id and optional size parameter, which matches the signature
 of `wp_get_attachment_image_srcset()` and is consistent with the other
 `wp_get_attachment_image_` template functions.

 Tests and docs have been updated.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34612#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform