[wp-trac] [WordPress Trac] #21389: Retina theme custom headers

[WordPress Trac]

#21389: Retina theme custom headers
-------------------------------------------------+-------------------------
 Reporter:  nacin                                |       Owner:  joemcgill
     Type:  task (blessed)                       |      Status:  assigned
 Priority:  normal                               |   Milestone:  4.4
Component:  Customize                            |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  responsive-images has-patch 2nd-     |     Focuses:
  opinion                                        |
-------------------------------------------------+-------------------------

Comment (by DH-Shredder):

 Replying to [comment:36 azaozz]:
 > This is a new function. If the themes want to have a class set, they
 will have to pass it in the (optional) `$attr` array:
 > {{{
 > $add_classes = array( 'class' => 'one two three' );
 > the_header_image_tag( $add_classes );
 > }}}
 >
 > This works in exactly the same way in all of the patches.

 Ah, I see what's going on, thanks.

 Chatted with @azaozz on this:
 The "extra" default styles from `wp_get_attachment_image()` from the first
 patch were fixing the display on my install, and shouldn't be there. These
 are intentionally not included in the second two patches, which in my test
 case meant an overflowing header.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/21389#comment:37>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform