[wp-trac] [WordPress Trac] #34561: Abstract some embed template code into functions

[WordPress Trac]

#34561: Abstract some embed template code into functions
------------------------------------+--------------------
 Reporter:  johnbillion             |       Owner:
     Type:  enhancement             |      Status:  new
 Priority:  normal                  |   Milestone:  4.4
Component:  Embeds                  |     Version:  trunk
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:
------------------------------------+--------------------

Comment (by swissspidy):

 [attachment:34561.2.diff] is a small update to the previous patch that
 removes a `<div class="wp-embed-footer">` from the template I missed
 before.

 > `the_embed_header()` is rather long. Maybe that part could be
 simplified?

 I'd say not in 4.4.

 > Also, should the `the_excerpt_embed()` function be used to print the
 'Nothing found' message on 404s?

 WordPress themes usually don't do that, so I'd say no.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34561#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform