[wp-trac] [WordPress Trac] #34599: PHP warning in wp-admin/includes/images.php

[WordPress Trac]

#34599: PHP warning in wp-admin/includes/images.php
--------------------------+------------------------------
 Reporter:  skithund      |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Media         |     Version:  4.3
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+------------------------------

Comment (by dd32):

 Can this instead be switched to `if ( $metadata ) { unset(
 $metadata['...']['..'] ); }`?

 Having it do `isset()` followed by `unset()` is confusing, but a truthy
 check makes it far mor explicit that the reason could be because it's
 false.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34599#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform