[wp-trac] [WordPress Trac] #33641: Add support for responsive images using srcset and sizes
WordPress Trac
noreply at wordpress.org
Thu Nov 5 07:58:27 UTC 2015
#33641: Add support for responsive images using srcset and sizes
----------------------------+--------------------------
Reporter: joemcgill | Owner: DH-Shredder
Type: task (blessed) | Status: closed
Priority: normal | Milestone: 4.4
Component: Media | Version:
Severity: normal | Resolution: fixed
Keywords: has-patch | Focuses:
----------------------------+--------------------------
Comment (by jaspermdegroot):
In two tests for `wp_calculate_image_srcset()` we were using a random size
name "yoav". This gives the impression that we are testing what happens if
an invalid size name is used, but we are not. The test helper function
`_get_image_size_array_from_name()` returns the default size array in this
case so we are testing the code with a normal size array.
In 33641.6.diff I removed this size name from the tests and I added a new
test that actually tests an invalid size name.
I thought this was the best place to add the patch even though the ticket
closed. Let me know if I should open a new ticket for it.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/33641#comment:27>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list