[wp-trac] [WordPress Trac] #34560: Server error after saving many revisions

WordPress Trac noreply at wordpress.org
Tue Nov 3 19:43:36 UTC 2015


#34560: Server error after saving many revisions
-------------------------------------------------+-------------------------
 Reporter:  pdfernhout                           |       Owner:
     Type:  defect (bug)                         |  adamsilverstein
 Priority:  normal                               |      Status:  assigned
Component:  Editor                               |   Milestone:  Future
 Severity:  major                                |  Release
 Keywords:  needs-unit-tests has-patch dev-      |     Version:  3.6
  feedback                                       |  Resolution:
                                                 |     Focuses:
-------------------------------------------------+-------------------------

Comment (by miqrogroove):

 Looks like a great improvement.  Just a couple style ideas:

 {{{SELECT COUNT(1)}}} should be {{{SELECT COUNT(*)}}} for performance.
 Asterisk is optimal for row counts in MySQL.

 {{{( $revision_count && $revision_count > 1 )}}} should be {{{(
 $revision_count > 1 )}}} for readability because any boolean value will
 not evaluate greater than one anyway.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34560#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list