[wp-trac] [WordPress Trac] #34558: PasswordHash uses PHP 4 style constructor

[WordPress Trac]

#34558: PasswordHash uses PHP 4 style constructor
--------------------------+-----------------------------
 Reporter:  mordauk       |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Users         |    Version:  trunk
 Severity:  normal        |   Keywords:
  Focuses:                |
--------------------------+-----------------------------
 The `PasswordHash` class has a PHP 4 style constructor which results in
 deprecated notices being thrown in PHP 7:

 {{{
 /**
  * PHP4 constructor.
  */
 public function PasswordHash( $iteration_count_log2, $portable_hashes ) {
         self::__construct( $iteration_count_log2, $portable_hashes );
 }
 }}}

 {{{
 Methods with the same name as their class will not be constructors in a
 future version of PHP; PasswordHash has a deprecated constructor
 }}}

 In 4.3, PHP4 style constructors were removed for `WP_Widget`. I'd love to
 see this get removed from `PasswordHash` as well, though I'm not entirely
 sure it being an upstream library means we just wait until they update it
 or we go ahead and resolve it here and push back upstream.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34558>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform